Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Fix counter show number of experimental rulesets - #17954

Merged
zoracon merged 1 commit into
EFForg:masterfrom
cschanaj:fix-counter
May 13, 2019
Merged

zoracon merged 1 commit into
EFForg:masterfrom
cschanaj:fix-counter

Conversation

@cschanaj

Copy link
Copy Markdown
Collaborator

Step to reproduce:

  1. Visit https://hk.yahoo.com/ or any site with some experimental rulesets applicable

  2. Observe the ruleset counter show wrong number: it shows the number of experimental rulesets instead of the number of all applicable rulesets.

If possible, I hope this can be merged before #17944 since it disrupts the UX.

@cschanaj
cschanaj requested review from Hainish and zoracon May 13, 2019 09:00
@cschanaj cschanaj added the ui label May 13, 2019
@zoracon

zoracon commented May 13, 2019

Copy link
Copy Markdown
Contributor

I actually had a branch with a fix for this since I noticed as well. But you beat me to it.

@zoracon zoracon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zoracon
zoracon merged commit 00df747 into EFForg:master May 13, 2019
@cschanaj
cschanaj deleted the fix-counter branch May 13, 2019 20:40
@zoracon zoracon mentioned this pull request May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants